Re: [PATCH 2/2] ata: octeon: Add compile test support

[Guenter Roeck]

On 6/21/23 21:26, Damien Le Moal wrote:
> On 6/22/23 12:01, Guenter Roeck wrote:
> > On 6/21/23 17:57, Damien Le Moal wrote:
> > > On 6/22/23 01:51, Guenter Roeck wrote:
> > > > On Wed, Jun 14, 2023 at 11:36:33AM -0600, Rob Herring wrote:
> > > > > Add COMPILE_TEST to enable building Cavium Octeon drivers in MIPS
> > > > > allyesconfig/allmodconfig builds. There's a dependency on MIPS headers,
> > > > > so other arches can't be enabled.
> > > > >
> > > > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> > > > > ---
> > > > > Tested on allmodconfig build. Not sure if there's other MIPS configs
> > > > > where this doesn't work. We'll see what 0-day says.
> > > >
> > > > Odd, in next-20230621 I get:
> > > >
> > > > Building mips:allmodconfig ... failed
> > >
> > > Indeed odd. Given that this is an allmodconfig, I would assume that
> > > CONFIG_CAVIUM_OCTEON_SOC is set ?
> >
> > No, it is not. CONFIG_CAVIUM_OCTEON_SOC is a choice option,
> > meaning only one of the choices can be set, and mips:allmodconfig
> > selects a different choice.
>
> OK. Then I think I need to drop this patch as I do not see how to allow
> COMPILE_TEST without CONFIG_CAVIUM_OCTEON_SOC being set.

That is a contradiction anyway. COMPILE_TEST implies that the target is
independent of any other compile flags. If it depends on CONFIG_CAVIUM_OCTEON_SOC,
overriding that with COMPILE_TEST does not make sense.

Guenter

> Rob ?
>
> > Guenter
> >
> > > > --------------
> > > > Error log:
> > > > ERROR: modpost: "__udivdi3" [drivers/ata/pata_octeon_cf.ko] undefined!
> > > > ERROR: modpost: "octeon_get_io_clock_rate" [drivers/ata/pata_octeon_cf.ko] undefined!
> > > > ERROR: modpost: "__tracepoint_ata_bmdma_stop" [drivers/ata/pata_octeon_cf.ko] undefined!
> > > > ERROR: modpost: "__traceiter_ata_bmdma_stop" [drivers/ata/pata_octeon_cf.ko] undefined!
> > > > ERROR: modpost: "__divdi3" [drivers/ata/pata_octeon_cf.ko] undefined!
> > > > make[2]: [scripts/Makefile.modpost:144: Module.symvers] Error 1 (ignored)
> > > > make[2]: *** No rule to make target 'kernel/locking/locktorture.ko', needed by '__modfinal'.  Stop.
> > > > make[1]: [Makefile:1933: modules] Error 2 (ignored)
> > > >
> > > > Guenter