Re: [PATCH v2 4/5] dt-bindings: clock: imx6ul: Support optional enet*_ref_pad clocks

From: Conor Dooley
Date: Wed Jun 21 2023 - 16:57:45 EST


On Wed, Jun 21, 2023 at 11:32:44AM +0200, Oleksij Rempel wrote:
> Extend the 'clocks' and 'clock-names' properties to support optional
> 'enet1_ref_pad' and 'enet2_ref_pad' clocks to resolve the following
> dtbs_check warning:
> imx6ul-prti6g.dtb: clock-controller@20c4000: clocks: [[17], [18], [19], [20], [21]] is too long
> imx6ul-prti6g.dtb: clock-controller@20c4000: clock-names: ['ckil', 'osc', 'ipp_di0', 'ipp_di1', 'enet1_ref_pad'] is too long
>
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/clock/imx6ul-clock.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml b/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml
> index be54d4df5afa2..3b71ebc100bf6 100644
> --- a/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml
> @@ -28,18 +28,24 @@ properties:
> const: 1
>
> clocks:
> + minItems: 4
> items:
> - description: 32k osc
> - description: 24m osc
> - description: ipp_di0 clock input
> - description: ipp_di1 clock input
> + - description: Optional lenet1_ref_pad or enet2_ref_pad clocks
> + - description: Optional lenet1_ref_pad or enet2_ref_pad clocks
^
Is the l intentional?
Otherwise,
Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Cheers,
Conor.

>
> clock-names:
> + minItems: 4
> items:
> - const: ckil
> - const: osc
> - const: ipp_di0
> - const: ipp_di1
> + - pattern: '^enet[12]_ref_pad$'
> + - pattern: '^enet[12]_ref_pad$'
>
> required:
> - compatible
> --
> 2.39.2
>

Attachment: signature.asc
Description: PGP signature