Re: [PATCH 2/2] scsi: bfa: fix function pointer type mismatch for state machines

[Arnd Bergmann]

On Wed, Jun 21, 2023, at 20:33, Kees Cook wrote:
> On Fri, Jun 16, 2023 at 11:22:10AM +0200, Arnd Bergmann wrote:
>> 
>> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> Thanks for all this! It's a lot of mechanical changes, but looks correct
> to me. One nit below...
>
> Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
>
>> [...]
>>  static void
>> -bfad_sm_uninit(struct bfad_s *bfad, enum bfad_sm_event event);
>> +bfad_sm_uninit(struct bfad_s *bfad, enum bfad_sm_event);
>>  static void
>> -bfad_sm_created(struct bfad_s *bfad, enum bfad_sm_event event);
>> +bfad_sm_created(struct bfad_s *bfad, enum bfad_sm_event);
>>  static void
>> -bfad_sm_initializing(struct bfad_s *bfad, enum bfad_sm_event event);
>> +bfad_sm_initializing(struct bfad_s *bfad, enum bfad_sm_event);
>>  static void
>> -bfad_sm_operational(struct bfad_s *bfad, enum bfad_sm_event event);
>> +bfad_sm_operational(struct bfad_s *bfad, enum bfad_sm_event);
>>  static void
>> -bfad_sm_stopping(struct bfad_s *bfad, enum bfad_sm_event event);
>> +bfad_sm_stopping(struct bfad_s *bfad, enum bfad_sm_event);
>>  static void
>> -bfad_sm_failed(struct bfad_s *bfad, enum bfad_sm_event event);
>> +bfad_sm_failed(struct bfad_s *bfad, enum bfad_sm_event);
>>  static void
>> -bfad_sm_fcs_exit(struct bfad_s *bfad, enum bfad_sm_event event);
>> +bfad_sm_fcs_exit(struct bfad_s *bfad, enum bfad_sm_event);
>
> This bit doesn't seem needed? i.e. why remove the prototype's argument
> names?

Right, my mistake. I went through a few revisions and first tried to
change the prototypes here, but later changed them back. I missed
this after I folded my intermediate steps back into a single patch.

    Arnd