Re: [PATCH] perf parse: Add missing newline to pr_debug message in evsel__compute_group_pmu_name()

From: Namhyung Kim
Date: Wed Jun 21 2023 - 13:25:39 EST


On Tue, Jun 20, 2023 at 1:32 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
>
> Hello,
>
> On Thu, Jun 15, 2023 at 7:47 PM Yang Jihong <yangjihong1@xxxxxxxxxx> wrote:
> >
> > The newline is missing for pr_debug message in
> > evsel__compute_group_pmu_name(), fix it.
> >
> > Before:
> >
> > # perf --debug verbose=2 record -e cpu-clock true
> > <SNIP>
> > No PMU found for 'cycles:u'No PMU found for 'instructions:u'------------------------------------------------------------
> > perf_event_attr:
> > type 1
> > size 136
> > { sample_period, sample_freq } 4000
> > sample_type IP|TID|TIME|PERIOD
> > read_format ID|LOST
> > disabled 1
> > inherit 1
> > mmap 1
> > comm 1
> > freq 1
> > enable_on_exec 1
> > task 1
> > sample_id_all 1
> > exclude_guest 1
> > mmap2 1
> > comm_exec 1
> > ksymbol 1
> > bpf_event 1
> > ------------------------------------------------------------
> > <SNIP>
> >
> > After:
> >
> > # perf --debug verbose=2 record -e cpu-clock true
> > <SNIP>
> > No PMU found for 'cycles:u'
> > No PMU found for 'instructions:u'
> > ------------------------------------------------------------
> > perf_event_attr:
> > type 1
> > size 136
> > { sample_period, sample_freq } 4000
> > sample_type IP|TID|TIME|PERIOD
> > read_format ID|LOST
> > disabled 1
> > inherit 1
> > mmap 1
> > comm 1
> > freq 1
> > enable_on_exec 1
> > task 1
> > sample_id_all 1
> > exclude_guest 1
> > mmap2 1
> > comm_exec 1
> > ksymbol 1
> > bpf_event 1
> > ------------------------------------------------------------
> > <SNIP>
> >
> > Signed-off-by: Yang Jihong <yangjihong1@xxxxxxxxxx>
>
> Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Applied to perf-tools-next, thanks!