Re: [for-next][PATCH 01/13] fgraph: Add declaration of "struct fgraph_ret_regs"

[Steven Rostedt]

Sending manually, as quilt mail didn't acknowledge some character in this
email, and it was rejected by lkml as wrong mime type.

-- Steve

On Wed, 21 Jun 2023 12:29:24 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> From: "Steven Rostedt (Google)" <rostedt@xxxxxxxxxxx>
> 
> In final testing of:
> 
>   https://patchwork.kernel.org/project/linux-trace-kernel/patch/1fc502712c981e0e6742185ba242992170ac9da8.1680954589.git.pengdonglin@xxxxxxxxxxxxxx/
>   "function_graph: Support recording and printing the return value of function"
> 
> The test failed due to a new warning found in the build:
> 
> kernel/trace/fgraph.c:243:56: warning: ‘struct fgraph_ret_regs’ declared inside parameter list will not be visible outside of this definition or declaration
> 
> Instead of asking to send another patch series, just add it and then apply
> the updates.
> 
> Signed-off-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>
> ---
>  kernel/trace/fgraph.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/kernel/trace/fgraph.c b/kernel/trace/fgraph.c
> index 218cd95bf8e4..ea3d7bb235d3 100644
> --- a/kernel/trace/fgraph.c
> +++ b/kernel/trace/fgraph.c
> @@ -236,6 +236,9 @@ static struct notifier_block ftrace_suspend_notifier = {
>  	.notifier_call = ftrace_suspend_notifier_call,
>  };
>  
> +/* fgraph_ret_regs is not defined without CONFIG_FUNCTION_GRAPH_RETVAL */
> +struct fgraph_ret_regs;
> +
>  /*
>   * Send the trace to the ring-buffer.
>   * @return the original return address.