Re: [PATCH v6 22/26] dt-bindings: devfreq: event: rockchip,dfi: Add rk3588 support

From: Conor Dooley
Date: Wed Jun 21 2023 - 12:12:42 EST


On Wed, Jun 21, 2023 at 09:41:59AM +0200, Sascha Hauer wrote:
> On Fri, Jun 16, 2023 at 08:05:33PM +0100, Conor Dooley wrote:
> > On Fri, Jun 16, 2023 at 08:20:57AM +0200, Sascha Hauer wrote:
> > > This adds rockchip,rk3588-dfi to the list of compatibles. Unlike ealier
> > > SoCs the rk3588 has four interrupts (one for each channel) instead of
> > > only one, so increase the number of allowed interrupts to four.
> > >
> > > Link: https://lore.kernel.org/r/20230524083153.2046084-23-s.hauer@xxxxxxxxxxxxxx
> >
> > It's unclear what the point of this link is.
>
> The link was added automatically by b4. I re-applied the series from the
> last one I sent just to be sure that I base my work for the new series
> on the one I sent last time. I didn't remember that b4 adds these links,
> I should have disabled that option.

Ah, I see.

> > My comment still stands about whether only the new compatible should be
> > permitted to have more than one interrupt. I don't recall a response to
> > that question on the last version.
>
> My personal take on this is that such additions make the bindings more
> readable by machines, but less by humans. That's why I don't have enough
> intrinsic motivation to make this change.

> Anyway, if you insist then I'll make it for the next round.

No, I don't insist. I just wanted to not be ignored.
Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Cheers,
Conor.

Attachment: signature.asc
Description: PGP signature