Re: [PATCH v2 1/2] clk: nuvoton: Add clk-ma35d1.h for driver extern functions

[Arnd Bergmann]

On Wed, Jun 21, 2023, at 05:16, Jacky Huang wrote:
> From: Jacky Huang <ychuang3@xxxxxxxxxxx>
>
> Moved the declaration of extern functions ma35d1_reg_clk_pll() and
> ma35d1_reg_adc_clkdiv() from the .c files to the newly created header
> file clk-ma35d1.h.
>
> Signed-off-by: Jacky Huang <ychuang3@xxxxxxxxxxx>


>  #define PLL_MAX_NUM		5
> @@ -20,19 +22,19 @@ static DEFINE_SPINLOCK(ma35d1_lock);
>  #define REG_CLK_PWRCTL		0x00
>  #define REG_CLK_SYSCLK0		0x04
>  #define REG_CLK_SYSCLK1		0x08
> -#define REG_CLK_APBCLK0		0x0C
> +#define REG_CLK_APBCLK0		0x0c
>  #define REG_CLK_APBCLK1		0x10
>  #define REG_CLK_APBCLK2		0x14
>  #define REG_CLK_CLKSEL0		0x18
> -#define REG_CLK_CLKSEL1		0x1C
> +#define REG_CLK_CLKSEL1		0x1c
>  #define REG_CLK_CLKSEL2		0x20
>  #define REG_CLK_CLKSEL3		0x24
>  #define REG_CLK_CLKSEL4		0x28
> -#define REG_CLK_CLKDIV0		0x2C
> +#define REG_CLK_CLKDIV0		0x2c
>  #define REG_CLK_CLKDIV1		0x30
>  #define REG_CLK_CLKDIV2		0x34
>  #define REG_CLK_CLKDIV3		0x38
> -#define REG_CLK_CLKDIV4		0x3C
> +#define REG_CLK_CLKDIV4		0x3c
>  #define REG_CLK_CLKOCTL		0x40
>  #define REG_CLK_STATUS		0x50
>  #define REG_CLK_PLL0CTL0	0x60

This part of the patch does not relate to the decription, it
looks like a minor cleanup that should be a separate patch.

The actual change looks good and required, but I can't apply it
if it's mixed with unrelated changes like this.

    Arnd