Re: [PATCH v1 0/3] meson saradc: add iio channels to read channel 7 mux inputs

From: Andy Shevchenko
Date: Wed Jun 21 2023 - 10:11:33 EST


On Wed, Jun 21, 2023 at 09:26:07AM +0300, George Stark wrote:
> From: George Stark <GNStark@xxxxxxxxxxxxxx>
>
> In meson saradc channel7 is connected to muxer which allows to measure
> inner sources like Vdd, GND, several Vdd dividers. This patch series
> adds independent iio channel (with label) for every chan7 mux input.
> Mux switch is handled transparent for clients.
> This functionality can help debug\test\calibrate adc.
> This code is relevant for all supported amlogic soc families

Code wise looks good to me, some remarks about commit messages and comments.

> This patch series was created after discussion [1], [2]
>
> [1] https://lore.kernel.org/lkml/20230524000111.14370-1-gnstark@xxxxxxxxxxxxxx/
> [2] https://lore.kernel.org/lkml/20230527214854.126517-1-gnstark@xxxxxxxxxxxxxx/

--
With Best Regards,
Andy Shevchenko