Re: [PATCH 1/1] ASoC: codecs: max98090: Allow dsp_a mode

[Maxim Kochetkov]

On 21.06.2023 15:26, Mark Brown wrote:
> On Wed, Jun 21, 2023 at 02:53:27PM +0300, Maxim Kochetkov wrote:
>
> > TDM mode for max98090 is dsp_a compatible. So allow it.
>
> >   		case SND_SOC_DAIFMT_DSP_A:
> > -			/* Not supported mode */
> > +			break;
>
> This is configuring DSP A identically to left justified mode, it looks
> like the format configuration needs at least some interlock with the TDM
> configuration.

According to datasheet MAX98090 supports only DSP_A (L data MSB after 
FRM LRC) TDM mode. Allowing this mode will let us proper configure CPU 
audio node via DT. Actual TDM mode activation is performed in 
max98090_set_tdm_slot() via M98090_REG_TDM_FORMAT/M98090_REG_TDM_CONTROL 
registers.