Re: [PATCH 2/9] dt-bindings: phy: qcom,m31: Document qcom,m31 USB phy

From: Krzysztof Kozlowski
Date: Wed Jun 21 2023 - 04:43:50 EST


On 20/06/2023 11:32, Varadarajan Narayanan wrote:

>
>> And then we have... existing bindings qcom,usb-hs-phy.yaml. Don't create
>> something similar with difference in the hyphen. Just use device
>> specific compatible thus device specific filename.
>
> qcom,usb-hs-phy.yaml seems to be for ULPI mode phy and the
> driver we are introducing is for UTMI. We would have to
> modify phy-qcom-usb-hs.c to accomodate M31. Will that be
> acceptable to phy-qcom-usb-hs.c owners/maintainers?

We don't talk about drivers here but bindings. Why would you need to
modify the driver when introducing new binding for different device?



Best regards,
Krzysztof