Re: [PATCH v1 09/43] clocksource: ep93xx: Add driver for Cirrus Logic EP93xx

[Andy Shevchenko]

On Wed, Jun 21, 2023 at 11:22 AM Nikita Shubin
<nikita.shubin@xxxxxxxxxxx> wrote:

...

> > > +       irq = irq_of_parse_and_map(np, 0);
> > > +       if (irq <= 0) {
> > > +               pr_err("ERROR: invalid interrupt number\n");
> > > +               ret = -EINVAL;
> >
> > Shadowed error in case of negative returned code. Why?
>
> Majority of clocksource drivers shadow it. Same like above.

It doesn't mean they are correct or using brand new APIs.

Can you use fwnode_irq_get() instead?
The shadowing is most likely due to nasty =0 comparison.

Also that ERROR is a bit weird, pr_err() is already on error level.

-- 
With Best Regards,
Andy Shevchenko