Re: [PATCH v3 1/3] dt-bindings: qspi: cdns,qspi-nor: Add clocks for StarFive JH7110 SoC

From: William Qiu
Date: Wed Jun 21 2023 - 02:47:28 EST




On 2023/6/19 20:17, Krzysztof Kozlowski wrote:
> On 19/06/2023 10:35, William Qiu wrote:
>> The QSPI controller needs three clock items to work properly on StarFive
>> JH7110 SoC, so there is need to change the maxItems's value to 3. Other
>> platforms do not have this constraint.
>>
>> Signed-off-by: William Qiu <william.qiu@xxxxxxxxxxxxxxxx>
>> Reviewed-by: Hal Feng <hal.feng@xxxxxxxxxxxxxxxx>
>> Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>> ---
>> .../bindings/spi/cdns,qspi-nor.yaml | 20 ++++++++++++++++++-
>> 1 file changed, 19 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
>> index b310069762dd..1b83cbb9a086 100644
>> --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
>> +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
>> @@ -26,6 +26,15 @@ allOf:
>> const: starfive,jh7110-qspi
>> then:
>> properties:
>> + clocks:
>> + maxItems: 3
>> +
>> + clock-names:
>> + items:
>> + - const: ref
>> + - const: ahb
>> + - const: apb
>
> You are duplicating top-level property. Define the items only in one
> place. If this list is applicable to everything, then in top-level property.
>
Only in JH7110 SoC need there clocks, other platforms do not have this constraint.
So I need to duplicating top-level property.
>> +
>> resets:
>> minItems: 2
>> maxItems: 3
>> @@ -38,6 +47,9 @@ allOf:
>>
>> else:
>> properties:
>> + clocks:
>> + maxItems: 1
>
> clock-names is missing. They must be in sync with clocks. What is the
> first clock?
>
But there are no clock-names before, should I add it?
>> +
>> resets:
>> maxItems: 2
>>
>> @@ -70,7 +82,13 @@ properties:
>> maxItems: 1
>>
>> clocks:
>> - maxItems: 1
>> + maxItems: 3
>
>
> You did not test it before sending. minItems is missing.
>
I will add it.
As for other platforms, should I use enum to constraint the clocks?
>> +
>> + clock-names:
>> + items:
>> + - const: ref
>> + - const: ahb
>> + - const: apb
>
>
>>
>> cdns,fifo-depth:
>> description:
>
> Best regards,
> Krzysztof
>
Thanks for taking time to review this patches series.

Best regards,
William