Re: [PATCH v2 04/16] mm: Change do_vmi_align_munmap() side tree index

From: Sergey Senozhatsky
Date: Tue Jun 20 2023 - 20:10:48 EST


On (23/06/20 09:04), Liam R. Howlett wrote:
> > On (23/06/12 16:39), Liam R. Howlett wrote:
> > [..]
> > > @@ -2450,17 +2452,17 @@ do_vmi_align_munmap(struct vma_iterator *vmi, struct vm_area_struct *vma,
> > > #if defined(CONFIG_DEBUG_VM_MAPLE_TREE)
> > > /* Make sure no VMAs are about to be lost. */
> > > {
> > > - MA_STATE(test, &mt_detach, start, end - 1);
> > > + MA_STATE(test, &mt_detach, 0, 0);
> > > struct vm_area_struct *vma_mas, *vma_test;
> > > int test_count = 0;
> > >
> > > vma_iter_set(vmi, start);
> > > rcu_read_lock();
> > > - vma_test = mas_find(&test, end - 1);
> > > + vma_test = mas_find(&test, count - 1);
> > > for_each_vma_range(*vmi, vma_mas, end) {
> > > BUG_ON(vma_mas != vma_test);
> > > test_count++;
> > > - vma_test = mas_next(&test, end - 1);
> > > + vma_test = mas_next(&test, count - 1);
> > > }
> > > rcu_read_unlock();
> > > BUG_ON(count != test_count);
> >
> > Something isn't quite working, I'm hitting BUG_ON(vma_mas != vma_test)
>
> Is this with next by any chance?

Oh yes, linux-next