Re: [PATCH v3] uml: Replace strlcpy with strscpy

From: Kees Cook
Date: Tue Jun 20 2023 - 16:30:08 EST


On Wed, 14 Jun 2023 00:36:04 +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
>
> [...]

Build tested with "ARCH=um".

Applied to for-next/hardening, thanks!

[1/1] uml: Replace strlcpy with strscpy
https://git.kernel.org/kees/c/e1ca49d0291a

--
Kees Cook