Re: [PATCHv2] dt-bindings: arm: socionext: add Synquacer platforms

From: Jassi Brar
Date: Tue Jun 20 2023 - 13:24:56 EST


On Tue, 20 Jun 2023 at 12:16, Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 20/06/2023 19:07, jaswinder.singh@xxxxxxxxxx wrote:
> > From: Jassi Brar <jaswinder.singh@xxxxxxxxxx>
> >
> > Socionext's DeveloperBox is based on the SC2A11B SoC (Synquacer).
> > Specify bindings for the platform and boards based on that.
> >
> > Signed-off-by: Jassi Brar <jaswinder.singh@xxxxxxxxxx>
> > ---
>
> Attach changelog after ---.
>
> > .../bindings/arm/socionext/synquacer.yaml | 29 +++++++++++++++++++
> > 1 file changed, 29 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/arm/socionext/synquacer.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/arm/socionext/synquacer.yaml b/Documentation/devicetree/bindings/arm/socionext/synquacer.yaml
> > new file mode 100644
> > index 000000000000..c582d9c31213
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/socionext/synquacer.yaml
> > @@ -0,0 +1,29 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/arm/socionext/synquacer.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Socionext Synquacer platform
> > +
> > +maintainers:
> > + - Masahisa Kojima <masahisa.kojima@xxxxxxxxxx>
> > + - Jassi Brar <jaswinder.singh@xxxxxxxxxx>
> > +
> > +description:
> > + Socionext SC2A11B (Synquacer) SoC based boards
> > +
> > +properties:
> > + $nodename:
> > + const: '/'
> > + compatible:
> > + oneOf:
> > + - items:
> > + - enum:
> > + - socionext,developer-box
> > + - socionext,synquacer
> > + - const: socionext,sc2a11b
>
> That's quite different change.
>
So it is not carrying your ack.

> What is synquacer in this case? You claim
> now it is a board, but based on previous discussions and U-Boot source
> it does not look like such.
>
I never made that claim. I said Kojima-san will confirm. He informed
Synquacer is a brand name.

Currently no code internally or externally differentiates between
SC2A11B and Synquacer and we might as well keep living with Synquacer
only. This patch is an attempt to be accurate.

-j