Re: [PATCH] kasan: add support for kasan.fault=panic_on_write

From: Andrey Konovalov
Date: Tue Jun 20 2023 - 12:27:39 EST


On Tue, Jun 20, 2023 at 4:49 PM Marco Elver <elver@xxxxxxxxxx> wrote:
>
> On Tue, Jun 20, 2023 at 03:56PM +0200, Andrey Konovalov wrote:
> ...
> > Could you move this to the section that describes the kasan.fault
> > flag? This seems more consistent.
>
> Like this?
>
>
> diff --git a/Documentation/dev-tools/kasan.rst b/Documentation/dev-tools/kasan.rst
> index 7f37a46af574..f4acf9c2e90f 100644
> --- a/Documentation/dev-tools/kasan.rst
> +++ b/Documentation/dev-tools/kasan.rst
> @@ -110,7 +110,9 @@ parameter can be used to control panic and reporting behaviour:
> - ``kasan.fault=report``, ``=panic``, or ``=panic_on_write`` controls whether
> to only print a KASAN report, panic the kernel, or panic the kernel on
> invalid writes only (default: ``report``). The panic happens even if
> - ``kasan_multi_shot`` is enabled.
> + ``kasan_multi_shot`` is enabled. Note that when using asynchronous mode of
> + Hardware Tag-Based KASAN, ``kasan.fault=panic_on_write`` always panics on
> + asynchronously checked accesses (including reads).
>
> Software and Hardware Tag-Based KASAN modes (see the section about various
> modes below) support altering stack trace collection behavior:

Yes, this looks great! Thanks!