Re: [Linux-stm32] [PATCH v1 7/7] ARM: dts: stm32: Add Octavo OSD32MP1-RED board

From: Ahmad Fatoum
Date: Tue Jun 20 2023 - 12:23:54 EST

On 20.06.23 17:13, Sean Nyekjaer wrote:
> Add support for the Octavo OSD32MP1-RED development board.
>
> General features:
> - STM32MP157C
> - 512MB DDR3
> - CAN-FD
> - HDMI
> - USB-C OTG
> - UART
>
> Signed-off-by: Sean Nyekjaer <sean@xxxxxxxxxx>
> Reviewed-by: Olivier Moysan <olivier.moysan@xxxxxxxxxxx>
> ---
> Changes since v0:
> - Adapted to use stm32mp15xx-osd32.dtsi
>
> .../arm/boot/dts/stm32mp157c-osd32mp1-red.dts | 226 ++++++++++++++++++
> 1 file changed, 226 insertions(+)
> create mode 100644 arch/arm/boot/dts/stm32mp157c-osd32mp1-red.dts
>
> diff --git a/arch/arm/boot/dts/stm32mp157c-osd32mp1-red.dts b/arch/arm/boot/dts/stm32mp157c-osd32mp1-red.dts
> new file mode 100644
> index 000000000000..2823857900de
> --- /dev/null
> +++ b/arch/arm/boot/dts/stm32mp157c-osd32mp1-red.dts
> @@ -0,0 +1,226 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
> +/*
> + * Copyright (C) Geanix ApS 2023 - All Rights Reserved
> + * Author: Sean Nyekjaer <sean@xxxxxxxxxx>
> + */
> +
> +/dts-v1/;
> +
> +#include "stm32mp157.dtsi"
> +#include "stm32mp15xc.dtsi"
> +#include "stm32mp15xx-osd32.dtsi"
> +#include "stm32mp15xxac-pinctrl.dtsi"
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/pinctrl/stm32-pinfunc.h>
> +
> +/ {
> + model = "Octavo OSD32MP1 RED board";
> + compatible = "octavo,stm32mp157c-osd32mp1-red", "st,stm32mp157";

Add extra compatible For OSD32 SiP in the middle here.

> +
> + aliases {
> + serial0 = &uart4;
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + };
> +
> + led {
> + compatible = "gpio-leds";
> +
> + blue {

I think binding checker will complain about this node name.

> + label = "heartbeat";
> + gpios = <&gpiod 11 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "heartbeat";
> + default-state = "off";

Does it make sense to have a heartbeat that's off by default?

> + };
> + };
> +};
> +
> +&ethernet0 {
> + status = "okay";
> + pinctrl-0 = <&ethernet0_rgmii_pins_a>;
> + pinctrl-1 = <&ethernet0_rgmii_sleep_pins_a>;
> + pinctrl-names = "default", "sleep";
> + phy-mode = "rgmii-id";
> + max-speed = <1000>;
> + phy-handle = <&phy0>;
> + st,eth-clk-sel;
> +
> + mdio0 {
> + #address-cells = <1>;
> + #size-cells = <0>;

Nitpick: place after compatible (Interesting stuff first).

> + compatible = "snps,dwmac-mdio";

new line.

> + phy0: ethernet-phy@0 {

@3

> + reg = <3>;
> + };
> + };
> +};
> +
> +
> +&i2s2 {
> + clocks = <&rcc SPI2>, <&rcc SPI2_K>, <&rcc CK_PER>, <&rcc PLL3_R>;
> + clock-names = "pclk", "i2sclk", "x8k", "x11k";
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&i2s2_pins_b>;
> + pinctrl-1 = <&i2s2_sleep_pins_b>;
> + status = "okay";
> +
> + i2s2_port: port {
> + i2s2_endpoint: endpoint {
> + remote-endpoint = <&sii9022_tx_endpoint>;
> + format = "i2s";
> + mclk-fs = <256>;
> + };
> + };
> +};
> +
> +&iwdg2 {
> + timeout-sec = <32>;
> + status = "okay";
> +};
> +
> +&pwr_regulators {
> + vdd-supply = <&vdd>;
> + vdd_3v3_usbfs-supply = <&vdd_usb>;
> +};
> +
> +&ltdc {
> + status = "okay";
> +
> + port {
> + ltdc_ep0_out: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&sii9022_in>;
> + };
> + };
> +};
> +
> +&i2c1 {
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&i2c1_pins_a>;
> + pinctrl-1 = <&i2c1_sleep_pins_a>;
> + status = "okay";
> + i2c-scl-rising-time-ns = <100>;
> + i2c-scl-falling-time-ns = <7>;
> + /delete-property/dmas;
> + /delete-property/dma-names;
> +
> + hdmi-transmitter@39 {
> + compatible = "sil,sii9022";
> + reg = <0x39>;
> + reset-gpios = <&gpiog 0 GPIO_ACTIVE_LOW>;
> + interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
> + interrupt-parent = <&gpiog>;
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&ltdc_pins_e>;
> + pinctrl-1 = <&ltdc_sleep_pins_e>;
> + status = "okay";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + sii9022_in: endpoint {
> + remote-endpoint = <&ltdc_ep0_out>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> + sii9022_tx_endpoint: endpoint {
> + remote-endpoint = <&i2s2_endpoint>;
> + };
> + };
> + };
> + };
> +};
> +
> +&sdmmc1 {
> + pinctrl-names = "default", "opendrain", "sleep";
> + pinctrl-0 = <&sdmmc1_b4_pins_a>;
> + pinctrl-1 = <&sdmmc1_b4_od_pins_a>;
> + pinctrl-2 = <&sdmmc1_b4_sleep_pins_a>;
> + cd-gpios = <&gpioe 7 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
> + disable-wp;
> + st,neg-edge;
> + bus-width = <4>;
> + vmmc-supply = <&v3v3>;
> + status = "okay";
> +};
> +
> +&sdmmc2 {
> + pinctrl-names = "default", "opendrain", "sleep";
> + pinctrl-0 = <&sdmmc2_b4_pins_a &sdmmc2_d47_pins_d>;
> + pinctrl-1 = <&sdmmc2_b4_od_pins_a>;
> + pinctrl-2 = <&sdmmc2_b4_sleep_pins_a &sdmmc2_d47_sleep_pins_d>;
> + non-removable;
> + no-sd;
> + no-sdio;
> + st,neg-edge;
> + bus-width = <8>;
> + vmmc-supply = <&v3v3>;
> + vqmmc-supply = <&vdd>;
> + mmc-ddr-3_3v;
> + status = "okay";
> +};
> +
> +&uart4 {
> + pinctrl-names = "default", "sleep", "idle";
> + pinctrl-0 = <&uart4_pins_a>;
> + pinctrl-1 = <&uart4_sleep_pins_a>;
> + pinctrl-2 = <&uart4_idle_pins_a>;
> + /delete-property/dmas;
> + /delete-property/dma-names;
> + status = "okay";
> +};
> +
> +&m_can1 {
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&m_can1_pins_d>;
> + pinctrl-1 = <&m_can1_sleep_pins_d>;
> + status = "okay";
> +};
> +
> +&usbh_ehci {
> + phys = <&usbphyc_port0>;
> + phy-names = "usb";
> + status = "okay";
> +};
> +
> +&usbh_ohci {
> + phys = <&usbphyc_port0>;
> + phy-names = "usb";
> + status = "okay";
> +};
> +
> +&usbotg_hs {
> + vbus-supply = <&vbus_otg>;
> +};
> +
> +&usbphyc {
> + status = "okay";
> +};
> +
> +&usbphyc_port0 {
> + phy-supply = <&vdd_usb>;
> +};
> +
> +&usbphyc_port1 {
> + phy-supply = <&vdd_usb>;
> +};
> +
> +&rtc {
> + status = "okay";
> +};
> +
> +&crc1 {
> + status = "okay";
> +};
> +
> +&dts {
> + status = "okay";
> +};

--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |