Re: [PATCH AUTOSEL 6.1 07/16] smb3: missing null check in SMB2_change_notify

From: Sasha Levin
Date: Tue Jun 20 2023 - 10:44:24 EST


On Fri, Jun 16, 2023 at 09:39:28PM +0200, Pavel Machek wrote:
Hi!

From: Steve French <stfrench@xxxxxxxxxxxxx>

[ Upstream commit b535cc796a4b4942cd189652588e8d37c1f5925a ]

If plen is null when passed in, we only checked for null
in one of the two places where it could be used. Although
plen is always valid (not null) for current callers of the
SMB2_change_notify function, this change makes it more consistent.

Changelog explains problem can not happen, so... is this important
enough to backport?

Have you confirmed whether it's indeed the case on all the trees we
support?

--
Thanks,
Sasha