Re: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver
From: kernel test robot
Date: Tue Jun 20 2023 - 06:54:21 EST
Hi Yuji,
kernel test robot noticed the following build warnings:
[auto build test WARNING on media-tree/master]
[also build test WARNING on linus/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Yuji-Ishikawa/dt-bindings-media-platform-visconti-Add-Toshiba-Visconti-Video-Input-Interface-bindings/20230620-120839
base: git://linuxtv.org/media_tree.git master
patch link: https://lore.kernel.org/r/20230620031111.3776-3-yuji2.ishikawa%40toshiba.co.jp
patch subject: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver
config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20230620/202306201839.92EOK4H7-lkp@xxxxxxxxx/config)
compiler: aarch64-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230620/202306201839.92EOK4H7-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306201839.92EOK4H7-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/media/platform/toshiba/visconti/viif.c:182:6: warning: no previous prototype for 'visconti_viif_hw_on' [-Wmissing-prototypes]
182 | void visconti_viif_hw_on(struct viif_device *viif_dev)
| ^~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/toshiba/visconti/viif.c:190:6: warning: no previous prototype for 'visconti_viif_hw_off' [-Wmissing-prototypes]
190 | void visconti_viif_hw_off(struct viif_device *viif_dev)
| ^~~~~~~~~~~~~~~~~~~~
drivers/media/platform/toshiba/visconti/viif.c: In function 'visconti_viif_probe':
>> drivers/media/platform/toshiba/visconti/viif.c:500:36: warning: variable 'of_id' set but not used [-Wunused-but-set-variable]
500 | const struct of_device_id *of_id;
| ^~~~~
--
>> drivers/media/platform/toshiba/visconti/viif_capture.c:604:6: warning: no previous prototype for 'visconti_viif_capture_switch_buffer' [-Wmissing-prototypes]
604 | void visconti_viif_capture_switch_buffer(struct cap_dev *cap_dev, u32 status_err,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/toshiba/visconti/viif_capture.c:1325:5: warning: no previous prototype for 'visconti_viif_capture_register_ctrl_handlers' [-Wmissing-prototypes]
1325 | int visconti_viif_capture_register_ctrl_handlers(struct viif_device *viif_dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/toshiba/visconti/viif_capture.c:1434:5: warning: no previous prototype for 'visconti_viif_capture_register' [-Wmissing-prototypes]
1434 | int visconti_viif_capture_register(struct viif_device *viif_dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/toshiba/visconti/viif_capture.c:1476:6: warning: no previous prototype for 'visconti_viif_capture_unregister' [-Wmissing-prototypes]
1476 | void visconti_viif_capture_unregister(struct viif_device *viif_dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
>> drivers/media/platform/toshiba/visconti/viif_isp.c:243:6: warning: no previous prototype for 'visconti_viif_l2_set_roi_path' [-Wmissing-prototypes]
243 | void visconti_viif_l2_set_roi_path(struct viif_device *viif_dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/toshiba/visconti/viif_isp.c:254:6: warning: no previous prototype for 'visconti_viif_l2_set_roi' [-Wmissing-prototypes]
254 | void visconti_viif_l2_set_roi(struct viif_device *viif_dev, const struct viif_l2_roi_config *param)
| ^~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/toshiba/visconti/viif_isp.c:699:5: warning: no previous prototype for 'visconti_viif_isp_main_set_unit' [-Wmissing-prototypes]
699 | int visconti_viif_isp_main_set_unit(struct viif_device *viif_dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/toshiba/visconti/viif_isp.c:773:5: warning: no previous prototype for 'visconti_viif_isp_sub_set_unit' [-Wmissing-prototypes]
773 | int visconti_viif_isp_sub_set_unit(struct viif_device *viif_dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/toshiba/visconti/viif_isp.c:1177:6: warning: no previous prototype for 'visconti_viif_isp_set_compose_rect' [-Wmissing-prototypes]
1177 | void visconti_viif_isp_set_compose_rect(struct viif_device *viif_dev,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/toshiba/visconti/viif_isp.c:1214:5: warning: no previous prototype for 'visconti_viif_isp_register' [-Wmissing-prototypes]
1214 | int visconti_viif_isp_register(struct viif_device *viif_dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/toshiba/visconti/viif_isp.c:1265:6: warning: no previous prototype for 'visconti_viif_isp_unregister' [-Wmissing-prototypes]
1265 | void visconti_viif_isp_unregister(struct viif_device *viif_dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
drivers/media/platform/toshiba/visconti/viif_isp.c:162: warning: Function parameter or member 'viif_dev' not described in 'viif_l2_set_roi_num_2'
drivers/media/platform/toshiba/visconti/viif_isp.c:192: warning: Function parameter or member 'viif_dev' not described in 'viif_l2_set_roi_num_1'
drivers/media/platform/toshiba/visconti/viif_isp.c:244: warning: Function parameter or member 'viif_dev' not described in 'visconti_viif_l2_set_roi_path'
drivers/media/platform/toshiba/visconti/viif_isp.c:255: warning: Function parameter or member 'viif_dev' not described in 'visconti_viif_l2_set_roi'
drivers/media/platform/toshiba/visconti/viif_isp.c:255: warning: Function parameter or member 'param' not described in 'visconti_viif_l2_set_roi'
>> drivers/media/platform/toshiba/visconti/viif_isp.c:255: warning: expecting prototype for viif_l2_set_roi(). Prototype was for visconti_viif_l2_set_roi() instead
drivers/media/platform/toshiba/visconti/viif_isp.c:287: warning: duplicate section name 'Return'
drivers/media/platform/toshiba/visconti/viif_isp.c:290: warning: Function parameter or member 'viif_dev' not described in 'viif_main_set_unit'
>> drivers/media/platform/toshiba/visconti/viif_isp.c:290: warning: expecting prototype for hwd_viif_main_set_unit(). Prototype was for viif_main_set_unit() instead
drivers/media/platform/toshiba/visconti/viif_isp.c:482: warning: duplicate section name 'Return'
drivers/media/platform/toshiba/visconti/viif_isp.c:485: warning: Function parameter or member 'viif_dev' not described in 'viif_sub_set_unit'
drivers/media/platform/toshiba/visconti/viif_isp.c:538: warning: Function parameter or member 'viif_dev' not described in 'viif_mux_start'
drivers/media/platform/toshiba/visconti/viif_isp.c:568: warning: duplicate section name 'Return'
drivers/media/platform/toshiba/visconti/viif_isp.c:570: warning: Function parameter or member 'viif_dev' not described in 'viif_mux_stop'
vim +/visconti_viif_hw_on +182 drivers/media/platform/toshiba/visconti/viif.c
178
179 /*=============================================*/
180 /* handling V4L2 framework */
181 /*=============================================*/
> 182 void visconti_viif_hw_on(struct viif_device *viif_dev)
183 {
184 /* Disable MPU */
185 viif_mpu_disable(viif_dev);
186 /* Enable HWAIF */
187 viif_hwaif_enable(viif_dev);
188 }
189
> 190 void visconti_viif_hw_off(struct viif_device *viif_dev)
191 {
192 /* Uninitialize HWD driver */
193 }
194
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki