Re: [PATCH v2 0/5] Add support for external dphy

From: Jack Zhu
Date: Tue Jun 20 2023 - 06:09:46 EST




On 2023/5/23 16:56, Jack Zhu wrote:
> This series adds support for external D-PHY and JH7110 SoC which has a Cadence
> MIPI-CSI2 RX controller. The driver is tested on VisionFive V2 board.
>

Hi everyone,

For this new version of patch, could you please help to review and give your comments?
Thanks a lot!

> PLEASE NOTE: this patch series was spun off from the v4 of another series that
> included CSI and ISP driver. You can check the comments for earlier version in
> the link below. I'm sorry that the first version link has been lost.
>
> v4 link: https://lore.kernel.org/all/20230413035541.62129-1-jack.zhu@xxxxxxxxxxxxxxxx/
> v3 link: https://lore.kernel.org/all/20230331121826.96973-1-jack.zhu@xxxxxxxxxxxxxxxx/
> v2 link: https://lore.kernel.org/all/20230310120553.60586-1-jack.zhu@xxxxxxxxxxxxxxxx/
>
> Current review status:
> - cdns,csi2rx.yaml:
> Reviewed by: Krzysztof Kozlowski
> Reviewed by: Laurent Pinchart
> - cdns-csi2rx.c
> Reviewed by: Laurent Pinchart
> - MAINTAINERS
> Reviewed by: Krzysztof Kozlowski
> Reviewed by: Laurent Pinchart
>
> Thanks to everyone who reviewed my work !
>
> Changes in v2:
> - Matched reset names in bindings.
>
> v1 link: https://lore.kernel.org/all/20230512102637.50917-1-jack.zhu@xxxxxxxxxxxxxxxx/
>
> Jack Zhu (5):
> media: dt-bindings: cadence-csi2rx: Convert to DT schema
> media: dt-bindings: cadence-csi2rx: Add resets property
> media: cadence: Add operation on reset
> media: cadence: Add support for external dphy
> media: cadence: Add support for JH7110 SoC
>
> .../devicetree/bindings/media/cdns,csi2rx.txt | 100 ---------
> .../bindings/media/cdns,csi2rx.yaml | 201 ++++++++++++++++++
> MAINTAINERS | 1 +
> drivers/media/platform/cadence/cdns-csi2rx.c | 107 ++++++++--
> 4 files changed, 294 insertions(+), 115 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/cdns,csi2rx.txt
> create mode 100644 Documentation/devicetree/bindings/media/cdns,csi2rx.yaml
>