Re: [PATCH] dt-bindings: timer: add Ralink SoCs timer documentation

From: Krzysztof Kozlowski
Date: Tue Jun 20 2023 - 06:00:37 EST


On 20/06/2023 11:51, Sergio Paracuellos wrote:
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + clocks:
>>> + maxItems: 1
>>> +
>>> + clock-names:
>>> + const: timer
>>
>> Names matching the module name are not really helpful, so drop it,
>> unless any existing user needs it.
>
> I am ok with dropping this. If you meant with an existing user
> something that is already mainlined in the kernel tree then I would

Yes.

> say there is no need for this 'clock-names'. I don't know about other
> places since these SoCs are pretty old and almost with nothing
> documented. I am doing the effort of trying to document all the stuff
> before porting some openWRT device tree files to the kernel (this
> timer driver is already included in 'arch/mips/ralink' so I am
> documenting already in-tree things). So I guess I should send v2
> removing this?

Yes, please.

Best regards,
Krzysztof