Re: [PATCH v9 00/14] pci: Work around ASMedia ASM2824 PCIe link training failures

From: Maciej W. Rozycki
Date: Tue Jun 20 2023 - 05:57:17 EST


On Fri, 16 Jun 2023, Bjorn Helgaas wrote:

> I agree that as I rearranged it, the workaround doesn't apply in all
> cases simultaneously. Maybe not ideal, but maybe not terrible either.
> Looking at it again, maybe it would have made more sense to move the
> pcie_wait_for_link_delay() change to the last patch along with the
> pci_dev_wait() change. I dunno.

I think the order of the changes is not important enough to justify
spending a lot of time and mental effort on it. You decided, so be it.
Thank you for your effort made with this review.

With this series out of the way I have now posted a small clean-up for
SBR code duplication between PCI core and an InfiniBand driver I came
across in the course of working on this series. See
<https://lore.kernel.org/r/alpine.DEB.2.21.2306200153110.14084@xxxxxxxxxxxxxxxxx/>.

Please have a look at your convenience.

Maciej