Re: [patch v3 3/7] x86/smp: Remove pointless wmb()s from native_stop_other_cpus()

From: Borislav Petkov
Date: Tue Jun 20 2023 - 04:48:11 EST


On Thu, Jun 15, 2023 at 10:33:54PM +0200, Thomas Gleixner wrote:
> The wmb()s before sending the IPIs are not synchronizing anything.
>
> If at all then the apic IPI functions have to provide or act as appropriate
> barriers.
>
> Remove these cargo cult barriers which have no explanation of what they are
> synchronizing.
>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> ---
> V3: Remove second instance and reword changelog - PeterZ
> ---
> arch/x86/kernel/smp.c | 6 ------
> 1 file changed, 6 deletions(-)

Reviewed-by: Borislav Petkov (AMD) <bp@xxxxxxxxx>

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette