RE: [PATCH 2/3] x86/vector: Replace IRQ_MOVE_CLEANUP_VECTOR with a timer callback

From: Li, Xin3
Date: Tue Jun 20 2023 - 03:48:06 EST


> > +/*
> > + * Called with vector_lock held
> > + */
>
> Instead of comments like that, I tend to add a lockdep_assert*() statement to the
> same effect. Which unlike comment actually validate the claim and since it's code
> it tends to not go stale like comments do.

neat, will do!

> > + bool rearm = false;
>
> lockdep_assert_held(&vector_lock);

My bad, didn't notice that quite a few functions in the file already do that.