Re: [PATCH 3/4] ARM: dts: qcom: ipq8064: drop spi-max-frequency from controller

From: Konrad Dybcio
Date: Mon Jun 19 2023 - 13:16:27 EST


On 19.06.2023 19:01, Krzysztof Kozlowski wrote:
> spi-max-frequency is a property of SPI device, not SPI controller. Drop
> it from the controller nodes. No functional impact expected because
> child SPI device already defines spi-max-frequency. This fixes
> dtbs_check warnings like:
>
> qcom-ipq8064-ap148.dtb: spi@1a280000: Unevaluated properties are not allowed ('spi-max-frequency' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dts | 1 -
> arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> index 104eb729c2d6..1796ded31d17 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> +++ b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> @@ -282,7 +282,6 @@ gsbi5: gsbi@1a200000 {
>
> spi4: spi@1a280000 {
> status = "okay";
> - spi-max-frequency = <50000000>;
>
> pinctrl-0 = <&spi_pins>;
> pinctrl-names = "default";
> diff --git a/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi b/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi
> index c5abe7151f14..17f65e140e02 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi
> @@ -30,7 +30,6 @@ gsbi5: gsbi@1a200000 {
>
> spi4: spi@1a280000 {
> status = "okay";
> - spi-max-frequency = <50000000>;
>
> pinctrl-0 = <&spi_pins>;
> pinctrl-names = "default";