Re: [PATCH net v1] Revert "net: phy: dp83867: perform soft reset and retain established link"

From: Andrew Lunn
Date: Mon Jun 19 2023 - 12:30:49 EST


On Mon, Jun 19, 2023 at 05:44:35PM +0200, Francesco Dolcini wrote:
> From: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
>
> This reverts commit da9ef50f545f86ffe6ff786174d26500c4db737a.
>
> This fixes a regression in which the link would come up, but no
> communication was possible.
>
> The reverted commit was also removing a comment about
> DP83867_PHYCR_FORCE_LINK_GOOD, this is not added back in this commits
> since it seems that this is unrelated to the original code change.
>
> Cc: Praneeth Bajjuri <praneeth@xxxxxx>
> Closes: https://lore.kernel.org/all/ZGuDJos8D7N0J6Z2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx/
> Fixes: da9ef50f545f ("net: phy: dp83867: perform soft reset and retain established link")
> Signed-off-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>

There has been plenty of time given for somebody to investigate this
regression, and nothing has happened. So i agree, lets revert it.

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew