Re: [PATCH v2 1/6] dt-bindings: mmc: mmci: Add st,stm32mp25-sdmmc2 compatible

[Krzysztof Kozlowski]

On 19/06/2023 13:51, Yann Gautier wrote:
> For STM32MP25, we'll need to distinguish how is managed the delay block.
> This is done through a new comptible dedicated for this SoC, as the
> delay block registers are located in SYSCFG peripheral.
> 
> Signed-off-by: Yann Gautier <yann.gautier@xxxxxxxxxxx>
> ---
> Changes in v2:
> - update dt-bindings file (remove bootloader reference and use enum)
> 
>  Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> index 1c96da04f0e53..2459a55ed540b 100644
> --- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> +++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> @@ -53,10 +53,11 @@ properties:
>          items:
>            - const: arm,pl18x
>            - const: arm,primecell
> -      - description: Entry for STMicroelectronics variant of PL18x.
> -          This dedicated compatible is used by bootloaders.
> +      - description: Entries for STMicroelectronics variant of PL18x.
>          items:
> -          - const: st,stm32-sdmmc2
> +          - enum:
> +              - st,stm32-sdmmc2
> +              - st,stm32mp25-sdmmc2

It's nicely visible that old stm32 entry was family-generic, not
device-specific, thus not really correct. :( I hope we can learn from
this for future stm submissions.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>


Best regards,
Krzysztof