Re: [PATCH net-next] mptcp: Reorder fields in 'struct mptcp_pm_add_entry'

From: Matthieu Baerts
Date: Mon Jun 19 2023 - 07:15:05 EST


Hi Christophe,

On 18/06/2023 11:46, Christophe JAILLET wrote:
> Group some variables based on their sizes to reduce hole and avoid padding.
> On x86_64, this shrinks the size of 'struct mptcp_pm_add_entry'
> from 136 to 128 bytes.
>
> It saves a few bytes of memory and is more cache-line friendly.

Good catch and thank you for having shared this patch, it looks good to me!

Reviewed-by: Matthieu Baerts <matthieu.baerts@xxxxxxxxxxxx>

Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net