Re: [PATCH v1 1/1] gpiolib: Drop unused domain_ops memeber of GPIO IRQ chip

From: Andy Shevchenko
Date: Mon Jun 19 2023 - 06:42:19 EST


On Sat, Jun 17, 2023 at 11:23:17AM +0100, Marc Zyngier wrote:
> On Sat, 17 Jun 2023 10:08:10 +0100,
> Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> > On Fri, Jun 16, 2023 at 3:53 PM Andy Shevchenko
> > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

(...)

> > > - /* Some drivers provide custom irqdomain ops */
> > > gc->irq.domain = irq_domain_create_simple(fwnode,
> > > gc->ngpio,
> > > gc->irq.first,
> > > - gc->irq.domain_ops ?: &gpiochip_domain_ops,
> > > + &gpiochip_domain_ops,
> >
> > We better run this by Marc Zyngier, and Thierry who introduced it.
> >
> > But some grepping and looking seems to conclude you are righ!
> > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> No objection from my end. If this is unused, let's kill it.

Grepping by two independent people and so far no complains from CI, I believe
the patch tells truth.

> Acked-by: Marc Zyngier <maz@xxxxxxxxxx>

Thank you!

--
With Best Regards,
Andy Shevchenko