Re: [PATCH v14 18/18] media: i2c: ds90ub953: Support non-sync mode

[Tomi Valkeinen]

On 16/06/2023 17:47, Andy Shevchenko wrote:
> On Fri, Jun 16, 2023 at 04:59:22PM +0300, Tomi Valkeinen wrote:
> > Add support for FPD-Link non-sync mode with external clock. The only
> > thing that needs to be added is the calculation for the clkout.
>
> ...
>
> > +	switch (priv->mode) {
> > +	case UB953_MODE_SYNC:
> > +		if (priv->hw_data->is_ub971)
> > +			return priv->plat_data->bc_rate * 160ull;
> > +		else
> > +			return priv->plat_data->bc_rate / 2 * 160ull;
>
> Redundant 'else'.

True, but I like the symmetry in:

if (foo)
	return 123;
else
	return 321;

> Do I understand correctly you don't want to fallthrough because it will give
> ±160 in the rate (depending if it's even or odd)?

Sorry, can you clarify? Fallthrough to what?

> > +	case UB953_MODE_NONSYNC_EXT:
> > +		/* CLKIN_DIV = 1 always */
> > +		return clk_get_rate(priv->clkin) * 80ull;
> > +
> > +	default:
> >   		/* Not supported */
> >   		return 0;
> >   	}