Re: [PATCH v5 1/2] axis-fifo: use devm_kasprintf() for allocating formatted strings

From: Prathu Baronia
Date: Mon Jun 19 2023 - 02:43:56 EST


On Sat, Jun 17, 2023 at 04:00:02PM +0200, Greg Kroah-Hartman wrote:
>
> You are doing two different things here, one is changing the allocation
> way, and the other is the name. If one of those things turns out to
> break something, we have to revert this whole thing.
>
> So please make this two different changes, one to change to use
> devm_kasprintf() and the second to change the naming scheme, ESPECIALLY
> as you do not mention the name change in the subject line. And that's
> going to be a user-visible change, so you need to make that VERY
> obvious.
Makes sense greg, will do in v6.

Prathu