Re: [PATCH v3 1/3] perf test: Add metric value validation test

[Ravi Bangoria]

>>> +grep -q Intel /proc/cpuinfo || (echo Skipping non-Intel; exit 2)
>>
>> This check doesn't seem to be working. On my Zen3 AMD machine:
> 
> Thanks for reporting this! I've update this search to "GenuineIntel" in v4 to help solve this issue. 
> Please check it out. 

I'm sorry. I should have been more elaborative.

What I mean was () in bash creates a sub shell and thus exits from
the sub shell. I think what you need is {}. Ex:

  grep -q Intel /proc/cpuinfo || { echo Skipping non-Intel; exit 2; }


>>   test child finished with 0
>>   ---- end ----
>>   perf metrics value validation: Ok
>>
>> I haven't yet investigated whether it's genuine or false positive.
>>
> Base on this final report, it validated some basic rules like the 12 metrics for positive value test and 2 metrics for single metric value checks. 
> The test script grabs metrics supported on the platform and generates validation rules that only include metrics in the supported list. 
> Therefore, it is not surprising that the check passes on your system. 

Got it.

Thanks,
Ravi