Re: [net-next PATCH v4 2/3] leds: trigger: netdev: add additional specific link duplex mode

From: Andrew Lunn
Date: Sun Jun 18 2023 - 16:12:05 EST


On Sat, Jun 17, 2023 at 01:53:54PM +0200, Christian Marangi wrote:
> Add additional modes for specific link duplex. Use ethtool APIs to get the
> current link duplex and enable the LED accordingly. Under netdev event
> handler the rtnl lock is already held and is not needed to be set to
> access ethtool APIs.
>
> This is especially useful for PHY and Switch that supports LEDs hw
> control for specific link duplex.
>
> Add additional modes:
> - half_duplex: Turn on LED when link is half duplex
> - full_duplex: Turn on LED when link is full duplex
>
> Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew