Re: [PATCH v2 00/23] arm64: qcom: sa8775p-ride: enable the first ethernet port

From: Bartosz Golaszewski
Date: Sat Jun 17 2023 - 15:24:34 EST


On Sat, Jun 17, 2023 at 9:16 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Thu, 15 Jun 2023 14:13:56 +0200 Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> >
> > There are three ethernet ports on sa8775p-ride. This series contains changes
> > required to enable one of the two 1Gb ports (the third one is 10Gb). We need
> > to add a new driver for the internal SerDes PHY, introduce several extensions
> > to the MAC driver (while at it: tweak coding style a bit etc.) and finally
> > add the relevant DT nodes.
>
> Did I already ask you how do you envision this getting merged?
> You have patches here for at least 3 different trees it seems.
> Can you post the stmmac driver changes + bindings as a separate series?
>

Sure, now that bindings got reviewed, I will resend the patches
separately. Them going through different trees won't break the build.

> > drivers/phy/qualcomm/phy-qcom-sgmii-eth.c | 451 ++++++++++++++++++
>
> Noob question - what's the distinction between drivers/phy and
> drivers/net/phy (or actually perhaps drivers/net/pcs in this case)?

Not sure, but it seems that most drivers in the latter are MDIO while
those in drivers/phy are all kinds of PHYs (USB, UFS, etc.).

Bart