Re: [PATCH v14 1/2] thermal: loongson-2: add thermal management support

[zhuyinbo]

Hi Daniel,

在 2023/6/12 下午10:22, Daniel Lezcano 写道:

...

> > +#define LOONGSON2_SOC_MAX_SENSOR_NUM            4
> > +
> > +#define LOONGSON2_TSENSOR_CTRL_HI            0x0
> > +#define LOONGSON2_TSENSOR_CTRL_LO            0x8
> > +#define LOONGSON2_TSENSOR_STATUS            0x10
> > +#define LOONGSON2_TSENSOR_OUT                0x14
>
> Please use BIT() macros


I learn about that BIT() is generally used to describe the functional
bit or control bit or status bits of a register, but these register was
some different register offset and not some control bit or status bit
So using BIT() here seems a bit inappropriate, Do you think so?


Thanks,
Yinbo