Re: [BUG] _regmap_raw_write() - divide-by-zero

From: Jim Wylder
Date: Fri Jun 16 2023 - 18:39:23 EST


Sorry for causing the grief.

For the description would it be something like "Max transfer size
supported on a write"?
Or does that still not describe it correctly?

Jim

On Fri, Jun 16, 2023 at 5:14 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Fri, Jun 16, 2023 at 02:58:24PM -0700, Russ Weight wrote:
>
> > The origination of the regmap->max_raw_write value is here:
> > https://github.com/torvalds/linux/blob/4973ca29552864a7a047ab8a15611a585827412f/drivers/base/regmap/regmap-spi-avmm.c#L663
> > > .max_raw_write = SPI_AVMM_VAL_SIZE * MAX_WRITE_CNT,
>
> > SPI_AVMM_VAL_SIZE is defined as 4, and MAX_WRITE_CNT is defined as 1
>
> This should add in some headroom for the value too.
>
> We should also fix the max_raw_write comments since it's a bit confusing
> between users and buses, though AFAICT nothing outside the core ever
> checks.