Re: [PATCH net-next v1 06/14] net: phy: add 1000baseT1 to phy_basic_t1_features

From: Andrew Lunn
Date: Fri Jun 16 2023 - 16:51:07 EST


On Fri, Jun 16, 2023 at 04:53:15PM +0300, Radu Pirea (NXP OSS) wrote:
> Add 1000baseT1 bit to phy_basic_t1_features.

Please add an explanation why this is safe. For example, why the
RTL9000AA does not start saying it supports 1000BaseT1_Full.

Has 1000BaseT1_Full been standardised? If there a feature bit in a
register to indicate the hardware supports it? That would be the
preferred method to determine what the hardware can do.

Andrew