Re: [PATCH AUTOSEL 6.1 20/33] ASoC: Intel: avs: Account for UID of ACPI device

From: Pavel Machek
Date: Fri Jun 16 2023 - 15:32:28 EST


Hi!

> Configurations with multiple codecs attached to the platform are
> supported but only if each from the set is different. Add new field
> representing the 'Unique ID' so that codecs that share Vendor and Part
> IDs can be differentiated and thus enabling support for such
> configurations.

Apparently this is preparation for something, but we should not need
it in AUTOSEL as noone will write the uid here.

Best regards,
Pavel

> +++ b/include/sound/soc-acpi.h
> @@ -170,6 +170,7 @@ struct snd_soc_acpi_link_adr {
> /* Descriptor for SST ASoC machine driver */
> struct snd_soc_acpi_mach {
> u8 id[ACPI_ID_LEN];
> + const char *uid;
> const struct snd_soc_acpi_codecs *comp_ids;
> const u32 link_mask;
> const struct snd_soc_acpi_link_adr *links;
> diff --git a/sound/soc/intel/avs/board_selection.c b/sound/soc/intel/avs/board_selection.c
> index 87f9c18be238d..87353b4b0cd73 100644
> --- a/sound/soc/intel/avs/board_selection.c
> +++ b/sound/soc/intel/avs/board_selection.c
> @@ -394,7 +394,7 @@ static int avs_register_i2s_boards(struct avs_dev *adev)
> }
>
> for (mach = boards->machs; mach->id[0]; mach++) {
> - if (!acpi_dev_present(mach->id, NULL, -1))
> + if (!acpi_dev_present(mach->id, mach->uid, -1))
> continue;
>
> if (mach->machine_quirk)

--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Attachment: signature.asc
Description: PGP signature