Re: [PATCH] drm/bridge: lt9611uxc: Add MODULE_FIRMWARE macro

From: Robert Foss
Date: Fri Jun 16 2023 - 09:47:46 EST


On Fri, Jun 16, 2023 at 2:13 PM Juerg Haefliger
<juerg.haefliger@xxxxxxxxxxxxx> wrote:
>
> The module loads firmware so add a MODULE_FIRMWARE macro to provide that
> information via modinfo.
>
> Signed-off-by: Juerg Haefliger <juerg.haefliger@xxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> index 583daacf3705..6b2a4f8d6f78 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> @@ -1019,3 +1019,5 @@ module_i2c_driver(lt9611uxc_driver);
>
> MODULE_AUTHOR("Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>");
> MODULE_LICENSE("GPL v2");
> +
> +MODULE_FIRMWARE("lt9611uxc_fw.bin");
> --
> 2.37.2
>

Can filename string be made into a macro, as it is used in two locations?

With that fixed, please add my r-b.


Rob.