Re: [PATCH] gpiolib: Fix irq_domain resource tracking for gpiochip_irqchip_add_domain()

From: Linus Walleij
Date: Fri Jun 16 2023 - 09:07:55 EST


On Fri, Jun 16, 2023 at 9:30 AM Michael Walle <mwalle@xxxxxxxxxx> wrote:

> Up until commit 6a45b0e2589f ("gpiolib: Introduce
> gpiochip_irqchip_add_domain()") all irq_domains were allocated
> by gpiolib itself and thus gpiolib also takes care of freeing it.
>
> With gpiochip_irqchip_add_domain() a user of gpiolib can associate an
> irq_domain with the gpio_chip. This irq_domain is not managed by
> gpiolib and therefore must not be freed by gpiolib.
>
> Fixes: 6a45b0e2589f ("gpiolib: Introduce gpiochip_irqchip_add_domain()")
> Reported-by: Jiawen Wu <jiawenwu@xxxxxxxxxxxxxx>
> Signed-off-by: Michael Walle <mwalle@xxxxxxxxxx>

Oh right.

I guess we can't devres it some way...
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij