Re: [PATCH] ASoC: amd: correct pm_runtime enable sequence

[kondaveeti, Arungopal]

On 6/13/2023 7:39 PM, Mark Brown wrote:
> On Wed, Jun 14, 2023 at 06:01:59AM +0530, Arun Gopal Kondaveeti wrote:
>
> > Replace pm_runtime_allow() with pm_runtime_mark_last_busy()
> > & pm_runtime_set_active() in pm_runtime enable sequence for
> > dma drivers.
> This says what the change does but it doesn't say why the old sequence
> was a problem and the new one is better.

pm_runtime_allow is not needed for child platform drivers .

Previous sequence as listed below which is incorrect.

enable sequence:

    pm_runtime_set_autosuspend_delay(&pdev->dev, ACP_SUSPEND_DELAY_MS);
    pm_runtime_use_autosuspend(&pdev->dev);
    pm_runtime_enable(&pdev->dev);
    pm_runtime_allow(&pdev->dev);

disable sequence:

pm_runtime_disable(&pdev->dev)

Replaced pm runtime enable sequence.