Re: [PATCH v4 3/3] drm/panel-fannal-c3004: Add fannal c3004 DSI panel

From: Linus Walleij
Date: Fri Jun 16 2023 - 07:44:34 EST


On Fri, Jun 16, 2023 at 11:57 AM Paulo Pavacic <pavacic.p@xxxxxxxxx> wrote:
> čet, 15. lip 2023. u 21:55 Linus Walleij <linus.walleij@xxxxxxxxxx> napisao je:
> >
> > I doubt that the display controller is actually by Fannal, but I guess
> > you tried to find out? We usually try to identify the underlying display
> > controller so the driver can be named after it and reused for more
> > display panels.
>
> Yes, of course, the controller is ST7701S.

Hm did you try to just refactor
drivers/gpu/drm/panel/panel-sitronix-st7701.c
to support your new panel?

One major reason would be that that driver knows what
commands actually mean and have #defines for them.

Yours,
Linus Walleij