Re: [PATCH v1 1/1] memory: export symbols for process memory related functions

[Matthias Brugger]

On 12/06/2023 16:21, Wei-chin Tsai (蔡維晉) wrote:
> On Sat, 2023-06-10 at 01:21 +0100, Matthew Wilcox wrote:
> >   
> > External email : Please do not click links or open attachments until
> > you have verified the sender or the content.
> >  On Fri, Jun 09, 2023 at 04:09:01PM +0000, Wei-chin Tsai (蔡維晉) wrote:
> > > > You haven't included any users of these new exports, so the
> > initial
> > > > reaction is going to be negative - please include the users of
> > these
> > > > new symbols in your patch set.
> > > We use these two export functions from our kernel module to get a
> > > specific user process's memory information and heap usage.
> > Furthermore,
> > > we can use such information to detect the memory leak issues. 
> > > 
> > > The example code is as follows:
> >
> > No.  You need to be submitting the code that will use the symbol *at
> > the
> > same time* as the patch to export the symbol.  No example code
> > showing
> > how it could be used.  Because if the user isn't compelling, the
> > patch
> > to export the symbol won't be applied either.
>
> Hi Matthew,
>
> Got it. The following attached patch file
> "v1-0001-memory-export-symbols-for-process-memory-related-.patch" is
> the patch including the users of these new symbols. Thanks.

Please send both patches as a single series, then we can start review process. I 
had a very quick look on the attached patch and it's missing a good commit 
message describing what the drivers is for and why you need it.

Regards,
Matthias

> Regards,
>
> Jim
>
> ************* MEDIATEK Confidentiality Notice ********************
> The information contained in this e-mail message (including any
> attachments) may be confidential, proprietary, privileged, or otherwise
> exempt from disclosure under applicable laws. It is intended to be
> conveyed only to the designated recipient(s). Any use, dissemination,
> distribution, printing, retaining or copying of this e-mail (including its
> attachments) by unintended recipient(s) is strictly prohibited and may
> be unlawful. If you are not an intended recipient of this e-mail, or believe
> that you have received this e-mail in error, please notify the sender
> immediately (by replying to this e-mail), delete any and all copies of
> this e-mail (including any attachments) from your system, and do not
> disclose the content of this e-mail to any other person. Thank you!