Re: [RESEND PATCH v4 -next] tty: serial: add panic serial helper

[Hongyu Xie]

在 2023/6/16 14:03, Greg KH 写道:
> On Fri, Jun 16, 2023 at 10:31:15AM +0800, Hongyu Xie wrote:
> > 在 2023/6/15 18:17, Greg KH 写道:
> > > On Wed, Jun 14, 2023 at 10:55:12AM +0800, Hongyu Xie wrote:
> > > > It was inspired by kgdboc.
> > > >
> > > > This is a debug module that allows you to get all kernel logs
> > > > after panic.
> > > >
> > > > Normally you need to attach a USB-to-UART tool or enable kdump
> > > > before panic happens to get log from kernel after panic. If you
> > > > didn't do that and kdump is not working, you can't get any log to
> > > > know what happened before panic. If you have a USB-to-UART tool
> > > > and the UART port on your computer is working. This module helps
> > > > you to get all kernel log after panic() is called.
> > > >
> > > > To use this, see Documentation/dev-tools/panic_serial_helper.rst.
> > > >
> > > > Tested on an arm64 device.
> > > >
> > > > Signed-off-by: Hongyu Xie <xiehongyu1@xxxxxxxxxx>
> > > > ---
> > >
> > > Why  is this a RESEND?  What's wrong with the previous version?
> > Nobody review v4 for over a week.
>
> That's fine, but you need to say _why_ this is being resent, otherwise
> we have no idea, and this just moves to the bottom of our review queue.
"Nobody review v4 for over a week." was the reason. I should resubmit 
the same patch or ping instead of using "RESEND", is that what you mean?

> thanks,
>
> greg k-h
thanks,

Hongyu Xie