Re: [PATCH net-next] splice, net: Fix splice_to_socket() to handle pipe bufs larger than a page

From: patchwork-bot+netdevbpf
Date: Fri Jun 16 2023 - 02:00:29 EST


Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@xxxxxxxxxx>:

On Wed, 14 Jun 2023 11:09:48 +0100 you wrote:
> splice_to_socket() assumes that a pipe_buffer won't hold more than a single
> page of data - but this assumption can be violated by skb_splice_bits()
> when it splices from a socket into a pipe.
>
> The problem is that splice_to_socket() doesn't advance the pipe_buffer
> length and offset when transcribing from the pipe buf into a bio_vec, so if
> the buf is >PAGE_SIZE, it keeps repeating the same initial chunk and
> doesn't advance the tail index. It then subtracts this from "remain" and
> overcounts the amount of data to be sent.
>
> [...]

Here is the summary with links:
- [net-next] splice, net: Fix splice_to_socket() to handle pipe bufs larger than a page
https://git.kernel.org/netdev/net-next/c/ca2d49f77ce4

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html