Re: [PATCH v2 03/15] dt-bindings: display: mediatek: merge: Add compatible for MT8188

[Shawn Sung (宋孝謙)]

Hi Krzysztof,

Thanks for the reminder, because MT8188 is not related to MT8173, I’ll
keep it as it is for now, however, I do find that MT8195 doesn’t exist
in this dt-bindings which it should be, so there may be conflicts when
this series is going to be merged.

Best regards,
Hsiao Chien Sung

On Thu, 2023-06-15 at 10:28 +0200, Krzysztof Kozlowski wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On 14/06/2023 09:31, Hsiao Chien Sung wrote:
> > Add compatible name for MediaTek MT8188 MERGE.
> > 
> > Signed-off-by: Hsiao Chien Sung <shawn.sung@xxxxxxxxxxxx>
> > ---
> >  .../devicetree/bindings/display/mediatek/mediatek,merge.yaml   | 3
> +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.y
> aml
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.y
> aml
> > index eead5cb8636e..5c678695162e 100644
> > ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.y
> aml
> > +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.y
> aml
> > @@ -27,6 +27,9 @@ properties:
> >        - items:
> >            - const: mediatek,mt6795-disp-merge
> >            - const: mediatek,mt8173-disp-merge
> > +      - items:
> > +          - const: mediatek,mt8188-disp-merge
> > +          - const: mediatek,mt8195-disp-merge
> 
> Linux next has something entirely different. I don't know the base
> here,
> but it's really, really different and it suggests you should add
> mt8188
> to an enum with mt8173.
> 
> Best regards,
> Krzysztof
>