Re: [PATCH v3 3/3] soc: loongson2_pm: add power management support

From: zhuyinbo
Date: Fri Jun 16 2023 - 00:02:06 EST




在 2023/6/16 上午9:54, Huacai Chen 写道:
Hi, Yinbo,

On Fri, Jun 16, 2023 at 9:45 AM zhuyinbo <zhuyinbo@xxxxxxxxxxx> wrote:

...



okay, I got it.


+}
+
+static void loongson2_power_button_irq_enable(void)

Using loongson2_pm_irq_enable is a little better.



Previously, you suggested that I combine loongson2_pm_irq_enable() and
power button irq enable code as loongson2_power_button_irq_enable, then
I remove the function loongson2_pm_irq_enable, in this case that I won't
be able to call loongson2_pm_irq_enable, so have I misunderstood your
meaning ? or only rename loongson2_power_button_irq_enable as
loongson2_pm_irq_enable ?
I'm very sorry for that. At first I only wanted to combine two
functions, but then I found the name loongson2_pm_irq_enable is
better. So just rename is OK. Thanks.



okay, I got it.

Thanks,
Yinbo