Re: [PATCH v3 00/21] Enable CET Virtualization

From: Yang, Weijiang
Date: Thu Jun 15 2023 - 21:02:17 EST



On 6/16/2023 8:00 AM, Sean Christopherson wrote:
On Thu, Jun 15, 2023, Sean Christopherson wrote:
Your cover letter from v2 back in April said the same thing. Why hasn't the patch
been posted? And what exactly is the issue? IIUC, setting CR4.CET with
MSR_IA32_S_CET=0 and MSR_IA32_U_CET=0 should be a nop, which suggests that there's
a KVM bug. And if that's the case, the next obvious questions is, why are you
posting known buggy code?
Ah, is the problem that the test doesn't set CR0.WP as required by CR4.CET=1?

Thanks for taking time to review this series!

Yes, due to CR0.WP bit is not set while CR4.CET is being set.

The check is imposed by patch-12.

I'll add the fixup patch together with next the version.