Re: [PATCH v4 03/24] x86/resctrl: Create helper for RMID allocation and mondata dir creation

[Reinette Chatre]

Hi James,

On 5/25/2023 11:01 AM, James Morse wrote:
> When monitorrring is support, each monitor and control group is allocated

"When monitorrring is support" -> "When monitoring is supported"?

> an RMID. For control groups, rdtgroup_mkdir_ctrl_mon() later goes on to
> allocate the CLOSID.
> 
> MPAM's equivalent of RMID are not an independent number, so can't be
> allocated until the CLOSID is known. An RMID allocation for one CLOSID
> may fail, whereas another may succeed depending on how many monitor
> groups a control group has.
> 
> The RMID allocation needs to move to be after the CLOSID has been
> allocated.
> 
> To make a subsequent change that does this easier to read, move the RMID
> allocation and mondata dir creation to a helper.

(nitpick) Could you please swap the two parts of the sentence to make the
changelog easier to parse? "Move the RMID allocation and mondata dir
creation to a helper to make the subsequent change that does this
easier to read."

> 
> Tested-by: Shaopeng Tan <tan.shaopeng@xxxxxxxxxxx>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> Signed-off-by: James Morse <james.morse@xxxxxxx>

Reinette