Re: [PATCH] regmap: Check for register readability before checking cache during read

From: Mark Brown
Date: Thu Jun 15 2023 - 16:55:19 EST


On Thu, Jun 15, 2023 at 10:45:53PM +0200, Konrad Dybcio wrote:
> On 13.06.2023 22:07, Mark Brown wrote:
> > Ensure that we don't return a spurious cache hit for unreadable registers
> > (eg, with the flat cache which doesn't understand sparseness) by checking
> > for readability before we do a cache lookup.

> this patch breaks using regmap_field_force_write() on fields that are
> parts of registers marked as write-only (e.g. by regmap_access_table.no_ranges)

> Is that intended?

> What's the recommended fix?

Ugh, let's just drop it - it's just an optimisation.

Attachment: signature.asc
Description: PGP signature